search

joaopereirawd / animatedModal.js

animatedModal.js is a jQuery plugin to create a fullscreen modal with CSS3 transitions. You can use the transitions from animate.css or create your own transitions.
MIT License
962 stars 207 forks source link

Proposal: Remove the background-color-property #5

Closed flash1293 closed 5 years ago

flash1293 commented 9 years ago

Wouldn't it be much easier to let the user set the background-color of his/her modal via css?

Talking about separation of concerns, IMHO the background-color of the modal is not a question of functionality (js), but a question of presentation (css).

rafic20 commented 9 years ago

Seconded. It seems more natural to allow users to change background colour (or image, or whatever) using CSS.

joaopereirawd commented 5 years ago

Yes, i understand your point of view. You can ignore js option and choose override the background-color with css.