5.22: Importing a bracket that hasn't started yet resulted in some players being put mistakenly into losers via DQ

joaorb64 / TournamentStreamHelper

101 stars 38 forks source link

5.22: Importing a bracket that hasn't started yet resulted in some players being put mistakenly into losers via DQ #301

Closed Tasabu closed 1 year ago

Tasabu commented 1 year ago

Issue is as it sounds. Imported a bracket before it started, and some players automatically got dq'd that shouldn't have. Not an issue with the overlay but the brackets feature itself. https://www.start.gg/tournament/castle-siege-31/event/ultimate-singles/brackets/1292780/1978020

Tasabu commented 1 year ago

When attempting this with another bracket at the same tournament, this does not happen https://www.start.gg/tournament/castle-siege-31/event/fire-emblem-squad-strike

Tasabu commented 1 year ago

I just repeated the issue with 28 players, but this time the 6 & 7 seeds mistakenly had their opponents dq'd, since the 4th seed naturally had a bye

Wolfy76700 commented 1 year ago

Here are a few extra brackets which mess up:

However the following works fine:

joaorb64 commented 1 year ago

Found the issue: When a bracket is not started, IDs follow the format: "preview_2004442_1_5". I sort the sets by ID, so preview_2004442_1_1 < preview_2004442_1_11 < preview_2004442_1_2