search

joaotavora / eglot

A client for Language Server Protocol servers
GNU General Public License v3.0
2.25k stars 200 forks source link

Add Markdown LSP via Marksman #1013

Closed artempyanykh closed 2 years ago

artempyanykh commented 2 years ago

Marksman is an LSP server for Markdown: https://github.com/artempyanykh/marksman

It supports a bunch of LSP features such as symbols, references, rename, diagnostics, etc. and already has integrations with a number of LSP clients.

Context: I'm the author of Marksman and recently started using it with Eglot. I figured it would be nice to have an out-of-the-box support.

manuel-uberti commented 2 years ago

It probably makes sense to update the Connecting to a server section of the README and NEWS.md as well since you're at it. :)

Edit: see https://github.com/joaotavora/eglot/pull/961/files for example.

joaotavora commented 2 years ago

Yes, please find similar pull requests and do all of those actions. Then do a commit entry like this

Add Foo server

* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add foo-server.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
artempyanykh commented 2 years ago

@manuel-uberti @joaotavora sounds good, thanks! I'll update the PR shortly.

artempyanykh commented 2 years ago

Pushed an update. LMK if this looks good now.