search

joaotavora / eglot

A client for Language Server Protocol servers
GNU General Public License v3.0
2.25k stars 200 forks source link

"Enthusiast" is not a good default setting for `eldoc-documentation-strategy` #1031

Closed samclearman closed 2 years ago

samclearman commented 2 years ago

Eglot sets eldoc-documentation-strategy to eldoc-documentation-enthusiast when it manages a buffer. In typescript, at least, this means that when you put the point over an error, you can't see what the error is. I think eldoc-documentation-compose-eagerly would be better? And/or make this configurable.

joaotavora commented 2 years ago

It is configurable. Just set it in eglot-managed-mode-hook. And this has been discussed often in this bug tracker (like https://github.com/joaotavora/eglot/issues/648) If you need to fix an error in the function call, it's better to see the arguments than to see the error, and that's why it is the default (if there were more lines available, a different default could have been chosen). You can see the error in other ways, see #898.

Also, if I'm not mistaken, you completely ignored some very capitalized instructions about not opening an issue for this. Why?