search

joaotavora / eglot

A client for Language Server Protocol servers
GNU General Public License v3.0
2.25k stars 200 forks source link

Add support for Java server https://github.com/georgewfraser/java-lan… #1097

Closed brown closed 1 year ago

brown commented 1 year ago

I have been using eglot with George Fraser's java-language-server for many months. This commit adds that server as a an alternative to the Eclipse-based language server for Java.

joaotavora commented 1 year ago

This is welcome, but read the readme more closely and you'll see that Eglot development has moved to Emacs itself. Can you submit a patch to its bug tracker?

brown commented 1 year ago

Yes, I can figure out how to do that. The README file here says this repo "may be used to rehearse patches that go through the GitHub CI tests" which made me think I could send proposed changes here.

joaotavora commented 1 year ago

Yes, I can figure out how to do that. The README file here says this repo "may be used to rehearse patches that go through the GitHub CI tests" which made me think I could send proposed changes here.

And you can, but I haven't got that setup yet. In any case there would be no CI tests for your particular server (which prompts the question, could you think of adding them? In case the setup is easier than jdtls's).

Anyway, please submit this as a patch to bug-gnu-emacs@gnu.org (just the eglot.el bit), CC me (or X-Debbugs-CC: me) in the email, mention this discussion and, if you want, the fact that I've approved it. Thanks.

brown commented 1 year ago

Thanks. I just sent a patch to bug-gnu-emacs but forgot to CC you.

On Tue, Nov 8, 2022 at 5:07 PM João Távora @.***> wrote:

Yes, I can figure out how to do that. The README file here says this repo "may be used to rehearse patches that go through the GitHub CI tests" which made me think I could send proposed changes here.

And you can, but I haven't got that setup yet. In any case there would be no CI tests for your particular server (which prompts the question, could you think of adding them? In case the setup is easier than jdtls's).

Anyway, please submit this as a patch to @.*** (just the eglot.el bit), CC me (or X-Debbugs-CC: me) in the email, mention this discussion and, if you want, the fact that I've approved it. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/joaotavora/eglot/pull/1097#issuecomment-1307890588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVMN7YP4NHPUOS7YBR2TWHLFLLANCNFSM6AAAAAAR2SRXN4 . You are receiving this because you authored the thread.Message ID: @.***>