search

joaotavora / eglot

A client for Language Server Protocol servers
GNU General Public License v3.0
2.21k stars 203 forks source link

eglot--mode-line-format when jsonrpc.el v1.0.22 is installed #1341

Closed XO39 closed 6 months ago

XO39 commented 6 months ago

Using both Eglot v1.15 and jsonrpc.el v1.0.22 will throw the following error (gopls v0.14.2):

Error during redisplay: (eval (eglot--mode-line-format)) signaled (wrong-type-argument hash-table-p nil)

And the mode-line shows empty square brackets [] instead of [eglot:project].

I'm not aware of any other issues, but just to be save I deleted the latest version of jsonrpc.el and it seems that eglot 1.15 works fine with the built-in version of jsonprc v.1.0.16.

It may not be a big issue but I thought latest versions of both packages will work together.

Is it possible that this issue is related to gopls and not to eglot? Didn't have the time yet to try eglot with other language than go.

joaotavora commented 6 months ago

You need to get latest Eglot from GNU devel ELPA (https://elpa.gnu.org/devel/) and I need to make a new Eglot release.

XO39 commented 6 months ago

After installing latest Eglot from GNU devel ELPA, I'm now getting this error:

[eglot] (warning) Invalid slot name: "#<eglot-lsp-server eglot-lsp-server-498a6338>", :events-buffer-config
joaotavora commented 6 months ago

You would have to get the latest jsonrpc.el from GNU devel ELPA, too for that to work.

Anyway this should be fixed soon, as I just tagged Eglot 1.16 and Jsonrpc 1.23. let me know how it goes.

XO39 commented 6 months ago

Yes, it's working now with Eglot 1.16 and Jsonrpc 1.23.

Thanks