search

joaotavora / eglot

A client for Language Server Protocol servers
GNU General Public License v3.0
2.25k stars 201 forks source link

[feature] Remove flymake-mode check from publishDiagnostics handler #596

Closed gagbo closed 3 years ago

gagbo commented 3 years ago

Since https://github.com/joaotavora/eglot/commit/da7ff4883d3108468265fdc16a217d8e6aff92f2, it is a lot harder to use flycheck or any other checker to handle diagnostics when the server sends publishDiagnostics message.

Before that, it was possible, as a client, to only call eglot-flymake-backend once on the buffer to properly set the internal eglot--current-flymake-report-fn and get updates when new diagnostics are received.

It would be amazing to be able to do that again :)

Also discussed (in length) in hlissner/doom-emacs#4471

purcell commented 3 years ago

I'll add attribution and adapt this, if it's okay.

Yes, of course.

purcell commented 3 years ago

I can't remember what bugged me about [flymake-show-diagnostics-buffer] but I'll try to remember and provide more useful feedback.

I remembered! It doesn't update automatically. A pretty trivial complaint, I know, but I like to keep the errors window open next to the code for certain types of work, and the flycheck version updates continuously as new checks take place.

purcell commented 3 years ago

Also, this is starting to come together: https://github.com/purcell/flymake-flycheck/blob/main/flymake-flycheck.el :grin:

joaotavora commented 3 years ago

Looks very good. I'll have a look later. Then I'd suggest requesting comments on emacs-devel and adding to non-gnu elpa or something.

I'll also look at your flymake bug report, I think that buffer should also update automatically, but I'm away from my computer right now.

João

On Sun, Apr 4, 2021, 02:18 Steve Purcell @.***> wrote:

Also, this is starting to come together: https://github.com/purcell/flymake-flycheck/blob/main/flymake-flycheck.el 😁

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/joaotavora/eglot/issues/596#issuecomment-812952737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC6PQYN7XDNRVSZRVFCNLDTG6V5NANCNFSM4WHXYAZA .