joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.28k stars 145 forks source link

[GUI] Partial Context menu #181

Open rprimus opened 6 years ago

rprimus commented 6 years ago

Mon Jul 16 18:07:25 BST 2018

System Info:
### System Info: - **OS**: - ProductName: Mac OS X - ProductVersion: 10.13.6 - BuildVersion: 17G65 - **Emacs**: GNU Emacs 26.1 (build 1, x86_64-apple-darwin17.7.0, Carbon Version 158 AppKit 1561.4) of 2018-06-14 - **Lisp**: SBCL 1.4.9 - **sly**: sly-20180715.603


Am going over 3. A SLY tour for SLIME users using a non-terminal (GUI) Emacs.

Initially, when right-clicking on a button, the complete context menu (including the equivalent keybindings) is presented.

If the user then clicks anywhere else in the frame and then returns to the button, the context menu presented (via right-click) does not contain the equivalent keybindings.

Is this by design?

sly-menu

joaotavora commented 6 years ago

Is this by design?

No. But it doesn't happen in my gtk build, so seems to be osx specific. A bug report should be made to Emacs using M-x report-emacs-bug, but perhaps containing a much shorter reproduction recipe. Something that pops a menu with a couple of commands bound to keys.

If you want to report it for SLY, you can mention it there, provided you explain in the recipe how to install it and see the problem. Analysis usually takes longer in those cases.

I'll try to come up with a simple elisp recipe if you can't.

rprimus commented 6 years ago

Tue Jul 17 00:18:44 BST 2018

Will have a look around.

rprimus commented 6 years ago

Tue Jul 17 01:06:15 BST 2018

Have just tried it on a different system:

System Info:
### System Info: - **OS**: Linux a9 4.15.13-x86_64-linode106 #1 SMP Tue Mar 27 14:42:14 UTC 2018 x86_64 GNU/Linux - **Emacs**: "GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.30)\n of 2018-07-11, modified by Debian" - **Lisp**: SBCL 1.4.9 - **sly**: commit cc0656cf705cbb493f255bc401f4d6aa32199422 (HEAD -> master, origin/master, origin/HEAD) Author: João Távora Date: Tue Jul 17 00:17:22 2018 +0100 Close #182: let be overriden when completing in REPL * contrib/sly-mrepl.el (sly-mrepl-mode-map): Don't bind return.


Am experiencing the same:

  1. Click anywhere in frame then right-click on any button - the keybindings are no longer displayed.

sly-completions-deb

Not the end of the world.

rprimus commented 6 years ago

Tue Jul 17 06:18:42 BST 2018

From NEWS.md:

Following a suggestion by Attile Lendvai to SLIME, mouse-1 is now activates SLY's "part buttons".

  1. What does the above mean/refer to?
  2. Could what is being experienced be:
    • expected behaviour
    • attributed to sly-button-define-part-action (line 57: lib/sly-buttons.el)?
joaotavora commented 6 years ago

Am experiencing the same:

Funny, I'm not.

Can you try this much simpler exercise?

emacs -Q
C-mouse-3 ;; hold down control and click the right mouse button

Do it a couple of times and tell me if the tooltips disappear the second time.

rprimus commented 6 years ago

Wed Jul 18 05:50:29 BST 2018

[Using macOS]:

Nope. In the *scratch* buffer, C-mouse-3 brings up the Lisp Interaction Mode tooltip (everytime).

emacs-q-c-mouse-3