search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.26k stars 142 forks source link

Toggle break on sticker should accept :before and :after #282

Open arichiardi opened 4 years ago

arichiardi commented 4 years ago

Hi @joaotavora,

I have scanned the code a bit and saw that in order for the :before and :after options to work in *break-on-sticker* we would need to pass the values down from emacs to slynk.

This is a fairly trivial change it seems even being new to the code base. I might tackle it in the near future but here is an issue to track it.

Thank you as usual :smile:!

joaotavora commented 4 years ago

But before starting to implement, you should decide how the interface should be, and we should come to an agreement on that. Two options? Three?

arichiardi commented 4 years ago

Right, we can have a multiple choice like:

(defcustom sly-stickers-break-when 'before-and-after
  :type '(choice (const :tag "Before and after" t)
                 (const :tag "Only Before" '(:before))
                 (const :tag "Only After" '(:after))
                 (const :tag "Never" nil))
  :group 'sly)

I was thinking something along those lines :smile: