search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.24k stars 140 forks source link

Don't wrap completing-read #475

Closed theothornhill closed 2 years ago

theothornhill commented 2 years ago

Sly wraps completing-read to force ido to provide better UX. This is interfering with completion frameworks that don't set the completing-read-function such as vertico and mct. Considering that these packages serve to provide better UX, this functionality shouldn't really be necessary. This might need a version bump, since it is a user visible change.

See: https://gitlab.com/protesilaos/mct/-/issues/9

theothornhill commented 2 years ago

Oops sorry didn't see https://github.com/joaotavora/sly/issues/473...

joaotavora commented 2 years ago

This is OK @theothornhill. Please make a NEWS change, and link #473 in the commit message. use push -f if you can.

theothornhill commented 2 years ago

Great news! Hopefully the news entry is ok. Updated the commit, should be good now.

joaotavora commented 2 years ago

I pushed this with some tweaks. Thanks!