search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.26k stars 142 forks source link

Fix nil find-tag-marker-ring in sly-edit-uses #479

Closed vindvaki closed 2 years ago

vindvaki commented 2 years ago

On newer versions of Emacs, find-tag-marker-ring has been removed. To push a marker, one should use xref-push-marker-stack instead.

joaotavora commented 2 years ago

Yes, have to fix this. I'll merge this later. Ping me if I forget.

mfiano commented 2 years ago

Oh so this is why my edit definition stack has been messed up for a couple weeks. @joaotavora pinging if you forgot :)

joaotavora commented 2 years ago

I just merged @theothornhill 's PR. This would have been mostly fine, too. but the other one had the well-crafted commit message that I appreciate. But thanks anyway @vindvaki and sorry for the long delay in attending to this.

vindvaki commented 2 years ago

Thanks for merging a fix! I've closed this because it's now redundant.