joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.23k stars 139 forks source link

sly-repl conflicts with the new completion navigation feature in Emacs 29. #533

Open BooAA opened 1 year ago

BooAA commented 1 year ago

Hi, thanks for the work. Below is the bug I encounter in Emacs 29 when using the built in completion UI. (e.g. disable sly-symbol-completion-mode).

In Emacs 29, a new feature is added to let users navigate and choose completions from the ordinary buffer and no need to jump to the *completion* buffer. (By M-up, M-down, M-RET) News from Emacs. It should look like screenshot below:

https://user-images.githubusercontent.com/32809182/190444166-ea189977-2fec-44e2-acaa-dd444a231f9a.mov

However, sly's repl seems to conflict with this feature. Below is the snippets I use to reproduce the bug:

(use-package sly
  :custom ((inferior-lisp-program "sbcl")
           (sly-symbol-completion-mode nil))) ;; disable sly's own fancy completion UI

Using M-up and M-down to navigate the candidates are fine, but pressing M-RET shows "text is read-only" and the candidates cannot be inserted. Screenshot below:

https://user-images.githubusercontent.com/32809182/190445767-44c79d02-01e4-4f0e-a8dd-6a163a2b9509.mov

joaotavora commented 1 year ago

Thanks for the report. I reproduced it.

Uthar commented 1 year ago

Same issue

Uthar commented 1 year ago

Hmmm, mabye an issue in Emacs. I get the same in inferior python mode.

Uthar commented 1 year ago

see bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58353

joaotavora commented 1 year ago

Very nice, thanks @Uthar