search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.23k stars 139 forks source link

add support for company-kind #541

Closed jidibinlin closed 1 month ago

jidibinlin commented 1 year ago

If we add company-kind support. completion front end such as corfu can get the kind information to implement more feature. For my purposes I can use it to make corfu support icon display when pop up the completion frame.

image
joaotavora commented 1 year ago

Looks good in principle, but please remove unrelated whitespace changes first.

jidibinlin commented 1 year ago

Alright, But I suggest you automatically delete whitespace when you save buffer. I will remove unrelated whitespace changes.

jidibinlin commented 1 year ago

@joaotavora please check it. Happy hacking.

jidibinlin commented 1 year ago

@joaotavora This pr can be merged?

joaotavora commented 1 year ago

No it needs better commit messages and better formatting. I don't have time right now so be patient. The idea is good. Maybe you can guess from other commits the coding standards

joaotavora commented 1 month ago

Fairly sure, this was fixed in https://github.com/joaotavora/sly/pull/634. So closing. Thanks.