search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.23k stars 139 forks source link

Add basic tests for sly-package-fu #591

Closed tdrhq closed 1 year ago

tdrhq commented 1 year ago

This is a no-op change that just adds a new test for sly-package-fu. We'll use this to demonstrate the issue in PR #560.

I ran these tests as make check-fancy. Let me know if that's the incorrect way of running tests, because on Emacs 28.0.50, a few of these tests are failing:

Ran 166 tests, 162 results as expected, 3 unexpected, 1 skipped (2023-04-23 16:58:01-0400, 3.024471 sec)
1 expected failures

3 unexpected results:
   FAILED  autodoc-tests-25
   FAILED  autodoc-tests-26
   FAILED  font-lock-magic-3

1 skipped results:
  SKIPPED  autodoc-space-1

On Emacs 30, a bunch of tests are failing, so I'm assuming that's not a supported version.

joaotavora commented 1 year ago

These tests are very welcome, and so is probably the fix to #560.

But I need some time alone with SLY to make adjustments to this and other PRs and show you the things I mean in practice. Then in future PR's you'll be able to get closer and closer to mergeable things :-)

Just give me some time, I have very little availability recently. Let's see next weekend. There's an awesome PR in #588 to review and verify for example. Maybe you can help me test that.

tdrhq commented 1 year ago

As for #588, I just want to add as a point of reference, that I trust @charJe's elisp and CL skills. (He built the Emacs mode for https://github.com/moderninterpreters/markup, so super-awesome engineer.)

tdrhq commented 1 year ago

Closing this PR, since all of this code is already in #560