search

joaotavora / sly

Sylvester the Cat's Common Lisp IDE
1.23k stars 139 forks source link

sly-button-define-part-action: Pass 'no-error to ‘sly-button-at’ #602

Closed mattbeshara closed 9 months ago

mattbeshara commented 1 year ago

I ran into the issue described in https://github.com/joaotavora/sly/issues/466 and this seems to fix it. This might be a nicer fix than the existing PR, given that it might have unintended side-effects to change or remove sly-db-frame-map's parent keymap.

mattbeshara commented 9 months ago

@joaotavora I've pinned this bug down to this single call to sly-button-at. Is there any chance this could be merged please?

joaotavora commented 9 months ago

Is there any chance this could be merged please?

Yes, I think I understand the problem. You narrowed it down to that one call that is effectively bothering you, but I had a look at the previous commit (that, afaik touches two such instances). And it wasn't incorrect I think.

So, please revert back to the earlier commit, if you can.

mattbeshara commented 9 months ago

No worries, how does it look now?

mattbeshara commented 9 months ago

Ping

joaotavora commented 9 months ago

Thanks @mattbeshara . Keep pinging me for this stuff, else I will forget it.

Next time, if you could follow the GNU Commit Changelog format in the messages, it will help a bit, as all I have to do is press the big green button. Else I find myself rewing the commit message, and that takes time. This should be descrited in the CONTRIBUTE.md file.

mattbeshara commented 9 months ago

Thank you! And I will read through that file and try to format the commit messages more appropriately next time.