search

joaquinanguera / aceR

An R package for processing ACE data
MIT License
3 stars 14 forks source link

Remove scripts #1

Closed duanmua closed 8 years ago

duanmua commented 8 years ago 
deleted:    R/plots-box.R
deleted:    R/plots-generate.R
deleted:    R/zzz-seacrest-standardize.R
deleted:    R/zzz-woodcock-transform.R
deleted:    scripts/proc_all.R
deleted:    scripts/proc_all_demographs.R
deleted:    scripts/proc_study_all_firstblock.R
deleted:    scripts/proc_study_brighten.R
deleted:    scripts/seacrest/first_block.R
deleted:    scripts/seacrest/make_plots.Rmd
deleted:    scripts/seacrest/make_plots_edits.Rmd

The new repo lives here: https://github.com/gazzlab/AceScripts

What do you think of leaving plotting to be the responsibility of the end users of the aceR library @josegallegos07 ? From our experience so far, we've had to tweak it to fit whatever particular analysis we're doing (often)

Edit: Or alternatively, should we keep make_box_plot and any adjustments we want to make script-side, add it on to what's returned?

josegallegos07 commented 8 years ago

I think its a good a idea to keep the plotting on the script-side. make_box_plot and make_box_plot_bulk were really just (limited) wrapper functions.