search

joaquinanguera / aceR

An R package for processing ACE data
MIT License
3 stars 14 forks source link

only bind demographics module for pids present in task data #16

Closed monicathieu closed 4 years ago

monicathieu commented 5 years ago

The way the demographics report is generated, it usually contains data for more pids than might be in our task data (for example sub_00x is in demographics data, but doesn't have any task data). Can we make it so that when the demo data binds to task data, it only happens for pids that are present in the task data?

To illustrate with merge because that's what I know how to use best we'd want: merge(task data, demo data, by="bid short", all.x=T NOT merge(task data, demo data, by="bid short", all=T) which is what the output looks like now.

Hopefully that made sense....

monicathieu commented 5 years ago

➤ Jessica Younger commented:

Let me know if the description turns up in the github issue or if I need to put it in a comment here

monicathieu commented 5 years ago

Quick update: the description WILL edit in Github if you change it in Asana. So you can keep on keeping on in Asana! This ask makes sense to me 👍 I'm actually kind of surprised that this isn't already the default behavior. It should be an easy change in the joining parameters to use the task data as the master and discard unmatched pids in the demos.