e-leib
commented
4 years ago Hi Monica,
I actually did not realize I could do this without saving the old columns with new names, but I've tested it only modifying the original columns and it works. I will make the change now. Please let me know if I've done this in the most efficient way, or if there is a simpler/prettier way of doing it!
On Sat, Sep 7, 2019 at 4:45 PM Monica Thieu notifications@github.com wrote:
@monicathieu requested changes on this pull request.
Hi Elena,
Thanks for catching and addressing this! This code looks fine. However, given that the original coding is incorrect, I'm fine with not creating any .uncorrected columns and just modifying the original columns (to avoid proliferation of columns in the data that may never get used). The raw files will still have whatever original coding there was so that should do as far as retaining original data.
This is ok to merge when you're able to make the small changes described above.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joaquinanguera/aceR/pull/18?email_source=notifications&email_token=AK72JJPFKDWPZWGGJ4CJTHLQIQ4J5A5CNFSM4IURN5UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD722XA#pullrequestreview-285191516, or mute the thread https://github.com/notifications/unsubscribe-auth/AK72JJLTRYCOA4IK5DIZJ6LQIQ4J5ANCNFSM4IURN5UA .
-- Elena Leib PhD Student Building Blocks of Cognition Lab bungelab.berkeley.edu University of California, Berkeley
The game was coding 2/6 as greater than 3/7, so for these two questions, condition, correct_response, and correct_button need to be reversed (if it was left, now needs to be right, etc.).