joaquinanguera / aceR

An R package for processing ACE data
MIT License
3 stars 14 forks source link

Ensure no duplicated column names after joining #48

Open monicathieu opened 8 months ago

monicathieu commented 8 months ago

At various points, demographics data are joined alongside task data. Make sure all appropriate columns are matched in the join call and that there are no ".x" and ".y"-suffixed columns!

The implementation may need to be handled separately for Nexus vs legacy Explorer data, bc the "demographic" columns that are bundled in with the raw module-level data aren't consistent between the two versions.

Re: testthat testing for this, I think there already is a test for this, but you may just need to update the test for Nexus data.

monicathieu commented 1 month ago

Per Jeci's testing, these columns are not getting joined correctly and should be checked:

v1.x

age.x handedness.x build.x language_i18n.x client_time_zone.x device_model.x device_type.x os_version.x