non ascii characters in manga titles produce a crash [Batoto]

joaquinpf / manga_downloader

Cross-platform, multi-site, multi-threaded manga downloader with over 5000 distinct mangas. Includes support for automated downloading via external .xml file and conversion for viewing on the Kindle.

MIT License

0 stars 0 forks source link

non ascii characters in manga titles produce a crash [Batoto] #1

Open 4re opened 10 years ago

4re commented 10 years ago

First of all, thx for your work on this script! I really apreciate it.

And just as the title says, here is a sample json file with some mangas that reproduce the crash: http://paste.kde.org/ptrh8zjcf/js5tre/raw

joaquinpf commented 10 years ago

Good find, I'll take a look at this one later today. Just so we are on the same page, you are using the "develop" branch right?

4re commented 10 years ago

Yes.

manga_downloader $ git status On branch develop Your branch is up-to-date with 'origin/develop'.

joaquinpf commented 10 years ago

I corrected the encoding issues but there are a few other things to adress:

It seems that the json had a couple of invalid lines. This one should work ok with the latest on develop: http://goo.gl/axA7Nc Notice that I removed the trailing commas in lines 6 and 11.
Single page chapters don't work. I added a new issue for this and will be addressed later (https://github.com/joaquinpf/manga_downloader/issues/2). This affects "The Game"

@4re: Could you please give it a spin? Everything but "The Game" should be working

4re commented 10 years ago

I'm still having these errors:

Exception in thread Thread-3:
Traceback (most recent call last):
File "/usr/lib64/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
File "/home/dani/BLACK/MANGA/manga_downloader/src/parsers/base.py", line 351, in run
    raise FatalError("Thread crashed while downloading chapter: %s" % str(exception))
FatalError: Thread crashed while downloading chapter: 'ascii' codec can't decode byte 0xe2 in position 19: ordinal not in range(128)

joaquinpf commented 10 years ago

Mmm, I've been unable to reproduce this one so far. Could you run it with the --verbose flag enabled? That should output better debug info, including a proper trace. Other than that, could you paste the full command line you are using? Thank you

4re commented 10 years ago

Sorry about the delay!

My json file. My usuall comand line: python2 ./manga.py -j ../../listTest.json And the output of python2 ./manga.py --verbose -j ../../listTest.json > ../../debug.txt 2>&1