search

joaquintorres / autosubsync-mpv

Automatic subtitle synchronization script for mpv media player
MIT License
135 stars 13 forks source link

Separate error message for incompatible sub #10

Closed lionslancer closed 3 years ago

lionslancer commented 3 years ago

When attempting to sync against an internal bitmap sub, the same error message is printed as if there had been no internal subs present at all. This happens because the sync engines are incompatible with bitmap subs. Adding a separate error message for incompatible sub types would signal to the user that the script is functioning properly and that they need to find a different subtitle.

Something along the lines of Couldn't extract internal subtitle. Internal subtitle filetype is incompatible. instead of Couldn't extract internal subtitle. Make sure the video has internal subtitles.

*Also, very minor detail, but changing Sync to an internal subtitle to simply Sync to internal subtitle causes to text to fully fit inside the textbox.

tatsumoto-ren commented 3 years ago

The text fits inside the box unless your font is wrong.

I'll fix the rest when the ability to choose what track to retime against is implemented.

lionslancer commented 3 years ago

Sounds good. How do you plan to implement track selection? If you can choose between all currently loaded subs then that sounds like a good way of killing two birds and implementing #8. Are you looking at track selection for audio as well?

tatsumoto-ren commented 3 years ago

Yes, iterating through loaded tracks is the best way.

tatsumoto-ren commented 3 years ago

Should be fixed now.