joarwilk / gql2flow

Convert a GraphQL Schema to a flow definition
97 stars 24 forks source link

Add headers support #35

Open StevenLangbroek opened 7 years ago

StevenLangbroek commented 7 years ago

I'm switching from using a GraphQL based service to my own CMS installation, and its security requirements are different, so I needed custom headers :). Some notes on this PR:

Furthermore, I think you're reaching the point where it might be good to add some integration-level testing (mocking out the network / fs), and some convention etc... Would you like me to add eslint, editorconfig, prettier and basic set up for more extensive testing?

StevenLangbroek commented 7 years ago

Hmm... the more I think about this, the more I lean towards just supporting the graphql-config standard. There's a parser available too. Thoughts?

Edit: I'd gladly do the legwork for this.

samhagan commented 7 years ago

This is a feature that we would like also. Either directly via headers flag or via .graphqlrc file. A work around at this point is to run the introspection query yourself, write to file, then pass the json to gql2flow.

StevenLangbroek commented 7 years ago

@samhagan if you want i have some time over the weekend, i could whip up a PR for using graphql-config...

samhagan commented 7 years ago

@StevenLangbroek one thing to consider, not related to the headers, is other configuration this package may need. For example, we're using custom scalar types that by default result in any flow types -- these can be fixed by passing many -t flags, but would be better configured in a .gql2flowrc file that could capture any configuration needs.