search

joatuapp / joatu-app

The JoatU application, written in Ruby on Rails and ChaplinJS.
GNU Affero General Public License v3.0
8 stars 3 forks source link

Remove X button, place 'logout' in top-right list #25

Closed joatu closed 9 years ago

joatu commented 9 years ago

Watching Johnny use the site, he accidentally logged out numerous times mistaking the X in the corner to mean a way to close an opened window within JoatU. I would suggest we remove it entirely and replace it with a button that will send people to a random person's profile within their community.

The logout option can be in the drop-down list on the top right.

undergroundwebdesigns commented 9 years ago

Seems like a good idea to me.

undergroundwebdesigns commented 9 years ago

Wait, when I previously read this I missed the part about sending people to a random profile within their community... can we skip that for now, and just move the "logout" to be spelled out? I really don't think a button that randomly brings you to some stranger's profile for no good reason makes any sense at all...

joatu commented 9 years ago

Agreed.

On Mon, Oct 27, 2014 at 8:54 PM, Alex Willemsma notifications@github.com wrote:

Wait, when I previously read this I missed the part about sending people to a random profile within their community... can we skip that for now, and just move the "logout" to be spelled out? I really don't think a button that randomly brings you to some stranger's profile for no good reason makes any sense at all...

Reply to this email directly or view it on GitHub https://github.com/joatuapp/joatu-app/issues/25#issuecomment-60695006.

TedEwanchyna commented 9 years ago

can i look at this? (how do i get assigned? do you assign this to me or do i assign it to myself or do i just comment here and then do a pull request?)

TedEwanchyna commented 9 years ago

I commented out the original logout code. The idea is it would be easier to put it back if we need to (I know, we are using git, so this is not necessary...). I thought, perhaps, we could add a "are you sure", instead of logging the person out. I added the logout to the menu on the right.