joatuapp / joatu-v2

The JoatU application, version 2. Written in Ruby on Rails.
https://alpha.joatu.org
GNU General Public License v3.0
27 stars 5 forks source link

Mobile Optimisation - Update Twitter Bootstrap #168

Closed joatu closed 5 years ago

joatu commented 5 years ago

If I'm not mistaken, the mobile environment was a lot more user-friendly before the list of updates started coming along. I believe this has to do with Twitter Bootstrap, and I believe it might not be integrated in the same way that it was before.

Perhaps once Twitter Bootstrap is back working properly, further optimisation could be put on the backburner.

joatu commented 5 years ago

Optimise a bit more for mobile

joatu commented 5 years ago

I'd add this into priorities of bugs before we bring new folks in.

rsmithlal commented 5 years ago

Can you give me more examples of how exactly is has changed? I can go through and improve the mobile layout and whatnot more generally, but is there something specific? Any screenshots exist of what it used to look like?

joatu commented 5 years ago

I'll try to find you some screenshots. Basically, the site shrunk down to the size of the screen. So the text got bigger and you only saw so many things at once. Especially for offers/requests/messages.

On Fri, Jan 25, 2019, 5:25 PM Robert Smith <notifications@github.com wrote:

Can you give me more examples of how exactly is has changed? I can go through and improve the mobile layout and whatnot more generally, but is there something specific?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joatuapp/joatu-v2/issues/168#issuecomment-457753429, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGivE3udWVu-elzqZAFLgZE-U9-27uxks5vG4RZgaJpZM4aR06H .

joatu commented 5 years ago

Depending on the size of the screen, you would see it differently. offers requests

joatu commented 5 years ago

I just tested this issue and it is a problem with Google Chrome on Mobile. It is not an issue with Google Chrome on PC. It is not an issue with Firefox on PC or Mobile.

rsmithlal commented 5 years ago

That's interesting, because I was finding that the responsive layout behaved as expected in Chrome on desktop when resizing the browser window, but as soon as I turned on mobile device emulation it stopped working. This is a very helpful finding, as it will help narrow down the search for a solution.

rsmithlal commented 5 years ago

I'm going to leave this in a comment for later. It seems like this could be responsible for the issues that we're seeing: https://www.w3schools.com/css/css_rwd_viewport.asp

rsmithlal commented 5 years ago

This should be finished now. Please test and confirm.