[Security] Bump carrierwave from 1.3.1 to 2.2.0

Bumps carrierwave from 1.3.1 to 2.2.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Server-side request forgery in CarrierWave

Impact

[CarrierWave download feature](https://github.com/carrierwaveuploader/carrierwave#uploading-files-from-a-remote-location has an SSRF vulnerability, allowing attacks to provide DNS entries or IP addresses that are intended for internal use and gather information about the Intranet infrastructure of the platform.

Patches

Upgrade to 2.1.1 or 1.3.2.

Workarounds

Using proper network segmentation and applying the principle of least privilege to outbound connections from application servers can reduce the severity of SSRF vulnerabilities. Ideally the vulnerable gem should run on an isolated server without access to any internal network resources or cloud metadata access.

Patched versions: ~> 1.3.2; >= 2.1.1 Unaffected versions: none

Sourced from The Ruby Advisory Database.

Code Injection vulnerability in CarrierWave::RMagick

Impact

CarrierWave::RMagick has a Code Injection vulnerability. Its #manipulate! method inappropriately evals the content of mutation option(:read/:write), allowing attackers to craft a string that can be executed as a Ruby code. If an application developer supplies untrusted inputs to the option, it will lead to remote code execution(RCE).

(But supplying untrusted input to the option itself is dangerous even in absence of this vulnerability, since is prone to DoS vulnerability - attackers can try to consume massive amounts of memory by resizing to a very large dimension)

Proof of Concept
class MyUploader &lt; CarrierWave::Uploader::Base
  include CarrierWave::RMagick
end
MyUploader.new.manipulate!({ read: { density: "1 }; p 'Hacked'; {" }}) # =&gt; shows "Hacked"
Patches

Upgrade to 2.1.1 or

... (truncated)

Patched versions: ~> 1.3.2; >= 2.1.1 Unaffected versions: none

Sourced from The GitHub Security Advisory Database.

Server-side request forgery in CarrierWave

Impact

CarrierWave download feature has an SSRF vulnerability, allowing attacks to provide DNS entries or IP addresses that are intended for internal use and gather information about the Intranet infrastructure of the platform.

Patches

Upgrade to 2.1.1 or 1.3.2.

Workarounds

Using proper network segmentation and applying the principle of least privilege to outbound connections from application servers can reduce the severity of SSRF vulnerabilities. Ideally the vulnerable gem should run on an isolated server without access to any internal network resources or cloud metadata access.

References

Server-Side Request Forgery Prevention Cheat Sheet

For more information

If you have any questions or comments about this advisory:

Open an issue in CarrierWave repo

Email me at mit.shibuya@gmail.com

Affected versions: < 1.3.2

Sourced from The GitHub Security Advisory Database.

Code Injection vulnerability in CarrierWave::RMagick

Impact

CarrierWave::RMagick has a Code Injection vulnerability. Its #manipulate! method inappropriately evals the content of mutation option(:read/:write), allowing attackers to craft a string that can be executed as a Ruby code. If an application developer supplies untrusted inputs to the option, it will lead to remote code execution(RCE).

(But supplying untrusted input to the option itself is dangerous even in absence of this vulnerability, since is prone to DoS vulnerability - attackers can try to consume massive amounts of memory by resizing to a very large dimension)

Proof of Concept
class MyUploader &lt; CarrierWave::Uploader::Base
  include CarrierWave::RMagick
end
MyUploader.new.manipulate!({ read: { density: "1 }; p 'Hacked'; {" }}) # =&gt; shows "Hacked"
Patches

Upgrade to 2.1.1 or 1.3.2.

Workarounds

Stop supplying untrusted input to #manipulate!'s mutation option.

... (truncated)

Affected versions: < 1.3.2

Release notes

Sourced from carrierwave's releases.

2.2.0

Added

libvips support through ImageProcessing::Vips and ruby-vips (@rhymes #2500, e8421978, 4ae8dc64)

Provide alternatives to whitelist/blacklist terminology as allowlist/denylist, while old ones are still available but deprecated (@grantbdev #2442, 4c3cac75, #2491)

Support for the latest version of RMagick (@mshibuya 88f24451)

Deprecated

#(content_type|extension)_whitelist, #(content_type|extension)_blacklist are deprecated. Use #(content_type|extension)_allowlist and #(content_type|extension)_denylist instead (@grantbdev #2442, 4c3cac75)

Fixed

Calculate Fog expiration taking DST into account (@mshibuya, f90e14ca, #2059)

Set correct content type on copy of fog files (@ZuevEvgenii #2503, 6682f7ac, #2487)

Fix fog-google support to pass acl_header for public read if fog is public (@yosiat #2525, #2426)

Fix various URL escape issues by escaping on URI parse error only (@mshibuya 3faf7491, #2457, #2473)

Fix instance variables @versions_to_* not initialized warning (@mshibuya c10b82ed, #2493)

Fix SanitizedFile#move_to wrongly detects content_type based on the path before move (@mshibuya a42e1b4c, #2495)

Fix returning invalid content type on text files (@inkstak #2474, #2424)

Skip content type and extension filters where possible (@alexpooley #2464)

Fix file's #url being called twice, which might be costly for non-local files (@skyeagle #2519)

Fix mime type detection failing with types which contain + symbol, such as image/svg+xml (@sylvainbx #2489)

Fix #cached? to return boolean instead of @cache_id value (@kmiyake #2510)

Fix mime type detection for MS Office files (@anthonypenner #2447)

Security

Fix Code Injection vulnerability in CarrierWave::RMagick (@mshibuya 387116f5, GHSA-cf3w-g86h-35x4)

Fix SSRF vulnerability in the remote file download feature (@mshibuya 012702eb, GHSA-fwcm-636p-68r5)

2.1.1

Security

Fix Code Injection vulnerability in CarrierWave::RMagick (@mshibuya 15bcf8d8, GHSA-cf3w-g86h-35x4)

Fix SSRF vulnerability in the remote file download feature (@mshibuya e0f79e36, GHSA-fwcm-636p-68r5)

2.1.0

Added

Support authenticated_url for Blackblaze provider(@kevivmatrix #2444)

Fixed

Fix Ruby 2.7 deprecations(@mshibuya 9a37fc9e)

Fix S3 path-style URL for host with dots for buckets that are placed in other regions than us-east-1(@Bonias #2439)

Make MiniMagick::Image constant absolute to prevent misleading 'uninitialized constant' error(@p8 #2437)

2.0.2

Fixed

Fix download causing nil error if the file has empty filename(@fukayatsu #2419, #2411)

2.0.1

Fixed

Fix #{column}_cache unintentionally removing files on assigning empty string(@mshibuya 22e8005e, #2412)

2.0.0

... (truncated)

Changelog

Sourced from carrierwave's changelog.

2.2.0 - 2021-02-23

Added

libvips support through ImageProcessing::Vips and ruby-vips (@rhymes #2500, e8421978, 4ae8dc64)

Provide alternatives to whitelist/blacklist terminology as allowlist/denylist, while old ones are still available but deprecated (@grantbdev #2442, 4c3cac75, #2491)

Support for the latest version of RMagick (@mshibuya 88f24451)

Deprecated

#(content_type|extension)_whitelist, #(content_type|extension)_blacklist are deprecated. Use #(content_type|extension)_allowlist and #(content_type|extension)_denylist instead (@grantbdev #2442, 4c3cac75)

Fixed

Calculate Fog expiration taking DST into account (@mshibuya, f90e14ca, #2059)

Set correct content type on copy of fog files (@ZuevEvgenii #2503, 6682f7ac, #2487)

Fix fog-google support to pass acl_header for public read if fog is public (@yosiat #2525, #2426)

Fix various URL escape issues by escaping on URI parse error only (@mshibuya 3faf7491, #2457, #2473)

Fix instance variables @versions_to_* not initialized warning (@mshibuya c10b82ed, #2493)

Fix SanitizedFile#move_to wrongly detects content_type based on the path before move (@mshibuya a42e1b4c, #2495)

Fix returning invalid content type on text files (@inkstak #2474, #2424)

Skip content type and extension filters where possible (@alexpooley #2464)

Fix file's #url being called twice, which might be costly for non-local files (@skyeagle #2519)

Fix mime type detection failing with types which contain + symbol, such as image/svg+xml (@sylvainbx #2489)

Fix #cached? to return boolean instead of @cache_id value (@kmiyake #2510)

Fix mime type detection for MS Office files (@anthonypenner #2447)

Security

Fix Code Injection vulnerability in CarrierWave::RMagick (@mshibuya 387116f5, GHSA-cf3w-g86h-35x4)

Fix SSRF vulnerability in the remote file download feature (@mshibuya 012702eb, GHSA-fwcm-636p-68r5)

2.1.1 - 2021-02-08

Security

Fix Code Injection vulnerability in CarrierWave::RMagick (@mshibuya 15bcf8d8, GHSA-cf3w-g86h-35x4)

Fix SSRF vulnerability in the remote file download feature (@mshibuya e0f79e36, GHSA-fwcm-636p-68r5)

2.1.0 - 2020-02-16

Added

Support authenticated_url for Blackblaze provider(@kevivmatrix #2444)

Fixed

Fix Ruby 2.7 deprecations(@mshibuya 9a37fc9e)

Fix S3 path-style URL for host with dots for buckets that are placed in other regions than us-east-1(@Bonias #2439)

Make MiniMagick::Image constant absolute to prevent misleading 'uninitialized constant' error(@p8 #2437)

2.0.2 - 2019-09-28

Fixed

Fix download causing nil error if the file has empty filename(@fukayatsu #2419, #2411)

2.0.1 - 2019-08-31

Fixed

Fix #{column}_cache unintentionally removing files on assigning empty string(@mshibuya 22e8005e, #2412)

2.0.0 - 2019-08-18

... (truncated)

Commits

13330a7 Version 2.2.0
ae31743 Fix CI failures
4ae8dc6 Remove the #vips! block argument and #manipulate!
e842197 Disable libvips image caching
f23e9aa Merge pull request #2500 from rhymes/rhymes/add-vips
8b978ab Remove binding.pry
aaa52b8 Merge branch 'master' into rhymes/add-vips
f90e14c Calculate Fog expiration taking DST into account
657f259 Update model base class to ApplicationRecord
1a0da9b Use allowlist/denylist terminology also for README
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)

joatuapp / joatu-v2

[Security] Bump carrierwave from 1.3.1 to 2.2.0 #374

Impact

Patches

Workarounds

Impact

Proof of Concept

Patches

Impact

Patches

Workarounds

References

For more information

Impact

Proof of Concept

Patches

Workarounds

2.2.0

Added

Deprecated

Fixed

Security

2.1.1

Security

2.1.0

Added

Fixed

2.0.2

Fixed

2.0.1

Fixed

2.0.0

2.2.0 - 2021-02-23

Added

Deprecated

Fixed

Security

2.1.1 - 2021-02-08

Security

2.1.0 - 2020-02-16

Added

Fixed

2.0.2 - 2019-09-28

Fixed

2.0.1 - 2019-08-31

Fixed

2.0.0 - 2019-08-18