Larger refactor of addon structure, by Oscarwika

[jobackman]

Big thanks to @oscarwika for this! https://github.com/oscarwika/SpellNotifications

• Now has sounds!!
  • Will play a buzz when your pet dies
• Code is a lot more readable and maintanable

Outside of @oscarwika contributions I made a few adjustments (no functional changes to addon users):

• Many of the functions defined were scoped to the Global object. I'd like to avoid cluttering the global scope, so that we dont run into any namespace collisions. So I now put them all into a single table SpellNoficiations that is available on the global scope.
  • So now we instead call addon.Colors() or addon.Messages() from within the addon
  • Or SpellNotifications.OnEvent(), SpellNotifications.Messages(), SpellNotifications.print() from outside the addon scope
• Re-used the Colors table in all the calls to addon.print, that way we dont need to do any extra lower-case checking for the strings sent
• New data table for the sizes we can print in, also used with all print calls
• A new Affiliations data table (perhaps there's a better name for it) for the combat log flag constants that are used to check the source and destination of the events
• Instead of a function that checks if events match and if the combat log flags are as expected, I made a new table of functions to be used with the Affiliation table:

-- There could be a better name than `cast.by`, `cast.on` etc. 
-- I just wanted it to be readable as viewed down below
local cast = {}
function cast.by(affiliation)
    return bit.band(sourceFlags, affiliation) > 0
end
function cast.on(affiliation)
    return bit.band(destFlags, affiliation) > 0
end
function cast.notOn(affiliation)
    return bit.band(destFlags, affiliation) <= 0
end

Used as:

if event=="SPELL_INTERRUPT" and cast.by(ME) then
-- ...
end

-- ...

if ((
    event == "UNIT_DIED" or
    event == "UNIT_DESTROYED" or
    event == "UNIT_DESTROYED") and
    cast.on(ME) and
    cast.on(PET)
) then 

-- ...

if event=="SPELL_MISSED" and cast.notOn(ME) then

[jobackman]

Btw if you want a more direct contact, msg me or something, you can add my discord user ~~ in case I dont respond. Im probably more likely to to respond there cause Isuck at checking my email so I miss a lot of GH notifications 😆

[jobackman]

Perhaps merge my PR into this branch before commiting to master?

Definitely 👍 I approved your PR when you I noticed that you pointed out it merges to this one 😋

[oscarwika]

Btw if you want a more direct contact, msg me or something, you can add my discord user LucyON#1510 in case I dont respond. Im probably more likely to to respond there cause Isuck at checking my email so I miss a lot of GH notifications 😆

Hahah, yeah sure. My GitHub notifications are also filtered to another folder as well so yeah 😆

[jobackman]

Hahah, yeah sure. My GitHub notifications are also filtered to another folder as well so yeah 😆

😱

[oscarwika]

Hahah, yeah sure. My GitHub notifications are also filtered to another folder as well so yeah 😆

😱

Hahah shit, I don't have that many 🤣