search

jobandtalent / AnimatedTextInput

Animated UITextField and UITextView replacement for iOS
MIT License
760 stars 128 forks source link

Fix counter label and add snapshot tests #53

Closed victorBaro closed 7 years ago

victorBaro commented 7 years ago

This PR fixes autolayout issues in the counter label.

It also adds snapshot tests to the project so hopefully this kind of bugs won't happen again in future releases.

seecahkhing commented 7 years ago

Hi @victorBaro : This would help a lot...Would it be OK to merge this one and have it released?

victorBaro commented 7 years ago

@seecahkhing I am waiting for a code review from one of my teammates. Will merge as soon as I have a 👍

In the meantime, you can refer your pod to this specific branch with something like: pod 'AnimatedTextInput', :branch => 'fix-counter-label'

seecahkhing commented 7 years ago

Got it.. I was able to do pod 'AnimatedTextInput', :git => 'https://github.com/jobandtalent/AnimatedTextInput.git', :branch => 'fix-counter-label'

One more thing though, the size of the font is always constant during typing and it's not using the Custom AnimatedTextInputStyle. This happens for .multiline style only...

http://imgur.com/a/9TD14

victorBaro commented 7 years ago

Well spotted @seecahkhing Thank you!

I have just fixed it here