Assessment Results - Githubissues

@jobbotrock You performed well enough on the assessment to merit a chance to make some changes that can promote you to technical ready. Please make the following updates by EOD Monday:

[ ] I'd like for you to revisit the instructions for the variables file here. I'd like you to give this a second pass through, making sure you hit every point, particularly steps 7 to 10. Also, step 3 asks to reassign the same food variable, but what I see is a new food variable being declared. Small error, but you will want to be mindful of reassignment versus new declaration.
[ ] I can tell you are conceptualizing classes well- great job there. For the next changes, I'll just look for updates in the class files (no need to also update instance files). In each class file, please update the class names to the Pascal Case convention.
[ ] For your first class, do you imagine that multiple elements would go in the color attribute array? If so, you may think about pluralizing the name. If not, a different data type may be more appropriate.
[ ] Also in your first class, lets look at method naming. Overall, well done, but a couple points to be made. First, you can go ahead and use camel case, though I am not concerned here as you've done snake case well, and that practice doesn't hurt as long as you know you will use javascript camel case more in the front end program. How might you name half_full in a more active way? For your last method, while you may want a method make_black if that is a color you change something to very frequently, how might you make a method that is more universal?
[ ] In your second class, how might you rename methods how_heavy and tape-measure to more match your method naming conventions?

Hi Mason,

Thanks for the feedback, I've updated my answers in github. Let me know if you need me to clarify anything,

Joe Varela,

On Sat, Mar 28, 2020 at 1:28 PM Mason France notifications@github.com wrote:

@jobbotrock https://github.com/jobbotrock You performed well enough on the assessment to merit a chance to make some changes that can promote you to technical ready. Please make the following updates by EOD Monday:

-

I'd like for you to revisit the instructions for the variables file here https://fierce-beyond-34376.herokuapp.com/confirmation. I'd like you to give this a second pass through, making sure you hit every point, particularly steps 7 to 10. Also, step 3 asks to reassign the same food variable, but what I see is a new food variable being declared. Small error, but you will want to be mindful of reassignment versus new declaration.

I can tell you are conceptualizing classes well- great job there. For the next changes, I'll just look for updates in the class files (no need to also update instance files). In each class file, please update the class names to the Pascal Case convention.

For your first class, do you imagine that multiple elements would go in the color attribute array? If so, you may think about pluralizing the name. If not, a different data type may be more appropriate.

Also in your first class, lets look at method naming. Overall, well done, but a couple points to be made. First, you can go ahead and use camel case, though I am not concerned here as you've done snake case well, and that practice doesn't hurt as long as you know you will use javascript camel case more in the front end program. How might you name half_full in a more active way? For your last method, while you may want a method make_black if that is a color you change something to very frequently, how might you make a method that is more universal?

In your second class, how might you rename methods how_heavy and tape-measure to more match your method naming conventions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jobbotrock/mod_0_skills/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO2OI2666KLY23ZQLQ54KCDRJZFXJANCNFSM4LVV33GQ .

jobbotrock / mod_0_skills

Assessment Results #1

I can tell you are conceptualizing classes well- great job there. For the next changes, I'll just look for updates in the class files (no need to also update instance files). In each class file, please update the class names to the Pascal Case convention.

For your first class, do you imagine that multiple elements would go in the color attribute array? If so, you may think about pluralizing the name. If not, a different data type may be more appropriate.