search

jobcespedes / docker-compose-moodle

This project quickly builds a local workspace for Moodle (Apache2, PHP-FPM with XDEBUG y Postgres) using containers for each of its main components. The local workspace is built and managed by Docker Compose
Apache License 2.0
52 stars 28 forks source link

Added a log file for the docker-compose-moodle_php-fpm_1 container to… #7

Closed paulterinho closed 4 years ago

paulterinho commented 4 years ago

Hi Job,

Feel free to ignore this proposed change. It just provides a local file for the logger to write to for XDebug.

Saludos,

scara commented 4 years ago

Hi @paulito-bandito,

log/xdebug.log: // Keep this log file out of GIT, do not commit!

why not listing that filename into the local .gitignore too?

HTH, Matteo

paulterinho commented 4 years ago

Hi Matteo,

Great idea! I'll add that next.

On Sun, Mar 15, 2020 at 3:50 PM Matteo Scaramuccia notifications@github.com wrote:

Hi @paulito-bandito https://github.com/paulito-bandito,

log/xdebug.log: // Keep this log file out of GIT, do not commit!

why not listing that filename into the local .gitignore http://../blob/e1a92826c2faa45eefea87b33aecdc3cda6a2e4b/.gitignore too?

HTH, Matteo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jobcespedes/docker-compose-moodle/pull/7#issuecomment-599255944, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLE2AGOIO2GIML3UNZZMU3RHUWQBANCNFSM4LLIEFXQ .

paulterinho commented 4 years ago

In addition to changing the ".gitignore" file, I also needed to change the "xdebug.remote_host=dockerhost" to "xdebug.remote_host=host.docker.internal" for the debugger to work on my dev machine (macos)

I can pull this change back out if that's not suitable.