search

jobisoft / DAV-4-TbSync

Mozilla Public License 2.0
161 stars 26 forks source link

Merges unrelated contacts (quite major issue) #30

Closed jobisoft closed 2 years ago

jobisoft commented 6 years ago

From @poVoq on September 18, 2018 12:7

Your environment

TbSync version: Dev version updated 30.August Thunderbird version: 60.0 (Windows10)

[ x ] Yes, I have installed the latest available (beta) version from https://github.com/jobisoft/TbSync/releases and my issue is not yet fixed, I can still reproduce it.

Expected behavior

When right clicking on contact in mail interface and selecting "edit contact" and then changing the Addressbook from a local to a CardDAV one it should copy the contact and delete it in the local one.

Actual behavior

The contact is deleted in the local one, but merged with an existing contact in the CardDAV Calendar (Some field get overwritten others ramain). It is not clear to me if it happens at random or based on some hidden numeric ID.

Steps to reproduce

See above.

Copied from original issue: jobisoft/TbSync#123

mMuck commented 5 years ago

I saw this behavior over several years now with SoGo Connector and the local "collected addresses" AB when I changed the AB from the local to the remote one. So this might be related to a greater context and not to TbSync itself. But, correct: Very critical. I'm glad I searched the entry afterwards and realized the overwritten fields/merged fields. No new entry was applied to the remote AB. I did no checks. Perhaps it's the same behavior with two local ABs and this is - as you mentioned - a problem with the underlying ID. I'm not in that TB dev stuff - could you please pass this on to the TB team and open an issue there? Thanks!

jobisoft commented 5 years ago

I will start investigating this mid December and will get back to you.

jobisoft commented 5 years ago

With TB 60.5 every contact now gets a UID. Maybe that fixes the problem? Can you check?

Does this also happens, when you drag‘n‘drop a contact from one address book to another?

poVoq commented 5 years ago

I noticed that after upgrading I had a lot more of these mixed contacts, but I guess that was just the transition?

jobisoft commented 5 years ago

If you disable and re-enable TbSync accounts (without syncing), all local modification are thrown away and you start with a fresh copy of your Contacts. Can you observe the behavior with TB 60.5?

And just to be sure, please switch to beta of TbSync before re-enabling your accounts: https://tbsync.jobisoft.de

jobisoft commented 5 years ago

Are we talking about this dialog: image

And not about dialogs from the actuall adressbook?

poVoq commented 5 years ago

Yeah, but by now things have gotten so confusing that I probably have to purge my entire address book and start new. Not a big deal, but I can't say for sure what is causing the issues and how to replicate as I have a lot of old "mixed" contacts by now.

jobisoft commented 5 years ago

That „switch address book“ function is a core TB function. TbSync only acts upon new or modified cards after they have been added/modified. If you observe merging of cards by using that switcher, it happens before TbSync sees them.

With new UID added to all cards starting with TB 60.4, this could be resolved?

I think this issue is not related to TbSync.

jobisoft commented 2 years ago

I am cleaning up older issues. Since Thunderbird 102, TbSync/DAV is using the native built-in CardDAV and CalDAV sync. TbSync is now only doing the simplified resource discovery, but any found calendar or address book is synced by Thunderbird.

Closing this issue, because it deals with the old TbSync CardDAV sync, which no longer exists. If this issue remains, it is a Thunderbird bug.