jobisoft / quicktext

An extension for Thunderbird that lets you create templates that can be easily inserted into your own emails.
Mozilla Public License 2.0
187 stars 53 forks source link

Phones tags stopped working with TB 102 #309

Closed cianoz closed 1 year ago

cianoz commented 2 years ago

Hello, just installed Thunderbird 102 and found that now the phones tags I've always used are not recognized anymore. I refer to [[FROM=phone]] and [[FROM=cellularnumber]] These 2 tags retrieved the phone numbers from the addressbook, but now with TB 102 they stopped working. Maybe the fields names are changed, but I couldn't find any reference for this in Mozilla documentation. I'm using version 5.0 of Quicktext.

jobisoft commented 2 years ago

The fields are no longer exposed, it is all stored in the vCard now. Hm.

jobisoft commented 2 years ago

quicktext_5_1.zip

Is this fixing it for you?

jobisoft commented 2 years ago

Nope, this one: quicktext511.zip

cianoz commented 2 years ago

Hello John, thanks for the quick reply Unfortunately the 511 version doesn't work here. After installing it the Quicktext bar on the new message window disappeared. My templates are still there but I can't call then in any way (no bar, no right click item

immagine

jobisoft commented 2 years ago

Sorry. Please try 5.1.2: quicktext_512.zip

cianoz commented 2 years ago

With the 5.1.2 the bar has come back, but phones numbers are still blank Since it's Sunday I'd say you'd have to enjoy your weekend John :-)

jobisoft commented 2 years ago

Can you try one of these property names: https://searchfox.org/comm-central/source/mailnews/addrbook/modules/VCardUtils.jsm#308-350

cianoz commented 2 years ago

Tried, but with no result Here is my test template: [[FROM=firstname]] [[FROM=lastname]]<br> [[FROM=custom1]] tel. [[FROM=WorkPhone]] <br> mob. [[FROM=CellularNumber]]

firstname and lastname work, the other tags don't

jobisoft commented 2 years ago

Works here: image

Hm. Do you have cardbook installed?

cianoz commented 2 years ago

Yes, I'm using CardBook along with the TB integrated addressbook I just tried on another PC without CardBook and here QuickText works. Sorry for the complication Up until now (with TB 91) I used CardBook along with the native addressbook and it worked. Maybe a bit of tuning and test are needed now with TB 102 to use both together. Thanks for your readiness and your great work.

cianoz commented 2 years ago

It looks that another detail has changed, to take note of: you have to use proper case writing field names / tags Now "WorkPhone" is recognized while "workphone" is not

jobisoft commented 2 years ago

Cardbook is triggering a different code path and tries to request these values through a cardbook API. I have to look at that.

I am currently adding the same code updates to the TO field collector.

Since it is a limited number of props, I could fix the casing manually (all those linked in https://github.com/jobisoft/quicktext/issues/309#issuecomment-1173041561)

I will report back.

jobisoft commented 2 years ago

quicktext_5.1.3.zip

This should now work with the old casing again:

[[FROM=firstname]] [[FROM=lastname]]<br> [[FROM=custom1]] tel. [[FROM=workphone]] <br> mob. [[FROM=cellularnumber]]

[[TO=firstname]] [[TO=lastname]]<br> [[TO=custom1]] tel. [[TO=workphone]] <br> mob. [[TO=cellularnumber]]

Can you confirm?

Looking at cardbook next.

jobisoft commented 2 years ago

CardBook: If the cardbook contact has the requested fields, this version should now work. Please also try after restarting Thunderbird:

quicktext_5.1.4.zip

Does that work for you, @cianoz ?

I think cardbook fails to properly convert TB contacts to CardBook contacts during the initial import, but this should not be related to what @cianoz observed.

jobisoft commented 2 years ago

released as 5.2 fingers crossed

SamuelPlentz commented 2 years ago

IMO close.