search

jobisoft / quicktext

An extension for Thunderbird that lets you create templates that can be easily inserted into your own emails.
Mozilla Public License 2.0
184 stars 52 forks source link

Error when inserting template with INPUT tag #348

Closed hiasr closed 1 year ago

hiasr commented 1 year ago

I created multiple templates and everything worked fine until adding an input tag. It is possible to create and save the template, but when trying to insert it, I get the following error: 

Uncaught (in promise) TypeError: Components.classes['@mozilla.org/embedcomp/prompt-service;1'] is undefined
    process_input chrome://quicktext/content/modules/wzQuicktextVar.jsm:663
    get_input chrome://quicktext/content/modules/wzQuicktextVar.jsm:346
    parseText chrome://quicktext/content/modules/wzQuicktextVar.jsm:176
    parse chrome://quicktext/content/modules/wzQuicktextVar.jsm:117
    insertSubject chrome://quicktext/content/quicktext.js:521
    insertTemplate chrome://quicktext/content/quicktext.js:362
    updateGUI chrome://quicktext/content/quicktext.js:278

I am currently running thunderbird beta 114.0b5 on Fedora, I tried this both on plugin version v5.3 and v5.5. Thank you in advance!

hiasr commented 1 year ago

I tried to look into this, and it seems that '@mozilla.org/embedcomp/prompt-service;1' is not a part anymore of thunderbird. I looked for an easy replacement but couldn't really find one. This means that the input tag will stop working in one of the following stable versions.

SamuelPlentz commented 1 year ago

jobisoft confirmed that the old INPUT Form gets deprecated in #281:

The underlying xul element has been deprecated. We need to convert to html.

jobisoft commented 1 year ago

I was wrong. It is still there, but is now only behind Services.prompt.* Fixed here: 92bd2bf48fa17ede2a8042b3cfb02f582cd4e01e

jobisoft commented 1 year ago

Please verify: https://github.com/jobisoft/quicktext/releases/tag/v5.6

hiasr commented 1 year ago

Solved! Thank you!

SamuelPlentz commented 1 year ago

I can confirm, that this is fixed in version 5.6.