search

jobisoft / quicktext

An extension for Thunderbird that lets you create templates that can be easily inserted into your own emails.
Mozilla Public License 2.0
184 stars 52 forks source link

Quicktext doesn't fully load in Thunderbird new message window opened from URL when Thunderbird is not open #402

Closed AdamBrezik closed 1 month ago

AdamBrezik commented 5 months ago
  1. Have Thunderbird closed (the process isn't running).
  2. Click on a mailto URL.

Expected: New message window opens with quicktext templates available. Actual: Quicktext icon is present in the corner, but template categories are missing and the button itself doesn't react.

If you deem this a Thunderbird issue instead, just let me know and I'll track it there.

jobisoft commented 5 months ago

Fixed in Thunderbird Beta.

jobisoft commented 5 months ago

Confirmation that it is fixed for you as well would be awesome :-)

AdamBrezik commented 5 months ago

Sorry, I just assumed. I can't get it working, actually. I can see the extension in Thunderbird, however it says "(disabled)" as a postfix and I can't seem to enable it. Tried to find many a solution for this but I'm so far unsuccessful. I got Quicktext 5.14.

jobisoft commented 5 months ago

Ah, that s because QT is not compatible yet with Beta. Loop of doom. I fixed the general issue in Thunderbird Beta, but forgot that I also have to make QT compatible with Beta.

matttbe commented 5 months ago

Hello

Sorry to jump in the discussion here with a non directly related issue: @jobisoft I was going to suggest a modification of the manifest file to support the new Beta version, then I saw your last comment:

QT is not compatible yet with Beta. Loop of doom. I fixed the general issue in Thunderbird Beta, but forgot that I also have to make QT compatible with Beta.

Is there something else that needs to be done to support the last Beta version? (I'm not an heavy user of QuickText, only using it to quickly insert 'Reviewed-by' tag in patch reviews -- but that's helpful, thank you for this add-on! :) -- maybe there are obscure options not working with the Beta?)

EDIT: I forgot to say: I modified the manifest in the .xpi file to accept 124.* versions, and installed it. It worked for my usage. I can prepare a new PR with that (or without the 'max' limit) if you want me to.

jobisoft commented 5 months ago

The max version setting is just the protection. I have to analyze the code to see if QT uses functions/methods which have been removed/renamed by Thunderbird. You will not see these fails directly, but some features will not work.

jobisoft commented 1 month ago

See https://github.com/jobisoft/quicktext/issues/411#issuecomment-2241755350