Closed ogrisel closed 1 year ago
I tested locally on Python 3.8 on Windows and the non-regression test passes. So I decided to just skip the test and pretend that Python 3.7 no longer exists which should be the case for loky 3.4.0 once we find a way to fix the broken bumped-up CI in #389.
Hum I am confused:
test_loky windows-py37
is actually launching the tests with Python 3.8 instead of Python 3.7;I checked again my local windows env, and I made a mistake... It was running Python 3.10. Apparently conda activate
does not work with the default windows 11 terminal, I had to use "miniforge prompt" instead.
I can reproduce and apparently 60 workers work well (instead of 61) on Python 3.8.
I do not understand why codecov complains about the warning not being covered. There is a test for this and it passes on the windows CI:
Ok I believe I understand why codecov is not 100% up to date:
I think we can merge. Hopefully this is a transient problem.
A quick review? Maybe @tomMoral @jeremiedbb or @thomasjpfan.
The windows py311 failure is already in main
and documented at #392. Merging.
Fixes #192.
loky.cpu_count
never returns more than 61 on Windows.I the user explicitly ask for more than 61 workers on Windows, a warning is raised and
max_workers
is automatically set back to the 61 limit.I added a new test that checks this by trying to spawn 62 workers. I ran the tests locally on windows and macos and it takes around 10-15s to run locally. I hope this will be ok on the CI, otherwise, I can disable it my default on (some) CI environments. Let's see.