search

joblike / joblike-service

Server side using nest.js
1 stars 1 forks source link

Feature/add register flow #17

Closed cawak closed 3 years ago

cawak commented 3 years ago

Issue: https://github.com/joblike/joblike-service/issues/15

cawak commented 3 years ago

@AlexGr2 took your comment and tried to fix some stuff, but of-course not everything. However, there are some notes I took for myself:

  1. Try to use a less of 'any' as I can. Yep, I'm writing in ts and not in js
  2. Use rx as much as I can - to avoid ifs. I see the benefit right now.
  3. As for the data.data. I agree, so I hid it elegantly.
  4. httpService - yes, I know. I'll do it as another task, once I see more usage of it, but of-course not too much. The main reason is to hide all this ugly code in one place.
  5. I will come back to this comment from time to time to check if I've worked on that. Thanks!