search

jobobby04 / TachiyomiSY

Free and open source manga reader for Android
Apache License 2.0
2.88k stars 156 forks source link

Show download state and progress on reader chapter list. #1263

Closed NGB-Was-Taken closed 1 month ago

NGB-Was-Taken commented 2 months ago

Issues with my implementation:

Closes #1207 (I am unsure whether #497 is mentioning this or something else and why Syer mentioned that it's intentional.)

jobobby04 commented 2 months ago

Is this good to merge? I saw a lot of talk about it in the discord

NGB-Was-Taken commented 2 months ago

Is this good to merge? I saw a lot of talk about it in the discord

Definitely not. It just "sort of" works. As I mentioned:

The download state and progress don't update until chapter is scrolled out of the screen and back or the chapter list dialogue is closed and re-opened.

I have managed to make it update when the state changes (not committed) . No luck on the progress though. I think I'll be quite busy this week and won't be able to work on this. Should I mark this as draft or something?

jobobby04 commented 2 months ago

Marking it as draft then 👍

NGB-Was-Taken commented 2 months ago

Should I add issue 497 to be closed by this? Context is lost without the images and I have no clue if it's mentioning this or something else.

cuong-tran commented 1 month ago

It still doesn't update the state after chapters are automatically deleted.

NGB-Was-Taken commented 1 month ago

It still doesn't update the state after chapters are automatically deleted.

How do you even check for that? Automatic deletion of chapters (as far as I know) is done only after the ReaderViewModel is closed. https://github.com/jobobby04/TachiyomiSY/blob/dea38912fc788f9dddc4a22f19a995c0b25f7933/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt#L318-L324