jobobby04 / TachiyomiSY

Free and open source manga reader for Android
Apache License 2.0
2.88k stars 156 forks source link

Syncyomi notification always says it succeeded, even though it failed #1280

Open jubiman opened 1 month ago

jubiman commented 1 month ago

Steps to reproduce

  1. Have a working syncyomi server and setup the credentials correctly on the TachiyomiSY app.
  2. Sync a library
  3. Make it fail on the server (in my case through an NGINX reverse proxy with a 413 status code because of incorrect config)

Expected behavior

Get a message saying that the sync was unsuccessful/failed

Actual behavior

Get a message saying the sync was successful

Crash logs

No response

TachiyomiSY version

Preview r564 (dea38912f, 9/2/24 02:23)

Android version

Android 14

Device

Google Pixel 8a running Graphine OS

Other details

I run syncyomi on a VPS behind an NGINX reverse proxy. I had not edited the client_max_body_size, which meant that whenever I tried to sync my (relatively large) library, it would return a 413 Request Entity Too Large. In the logs this is reflected with a SyncError: <webpage>, however, the mobile push notification says that the sync was successful, which it was not.

Acknowledgements