jobobby04 / TachiyomiSY

Free and open source manga reader for Android
Apache License 2.0
2.72k stars 146 forks source link

MangaDex alternative titles in description not working #903

Open Mythos opened 1 year ago

Mythos commented 1 year ago

Steps to reproduce

https://github.com/tachiyomiorg/tachiyomi-extensions/pull/16607 has added appending alternative titles to the description of the manga.

Expected behavior

When the setting is enabled, it should append the alternative titles upon updating the entry.

Actual behavior

With TachiyomiSY it does not append the alternative titles. In Tachiyomi it does append the alt titles.

Crash logs

No response

Tachiyomi version

Preview r552

Android version

Android 11

Device

Lenovo Tab P11

Other details

No response

Acknowledgements

Mythos commented 1 year ago

I thought extensions work on their own, that why you have to update them separately? If TachiyomiSY as its own custom implementation of fetching descriptions from MangaDex, I'll close the issue.

Otherwise it's IMHO a valid issue, as it doesn't work together with extensions correctly. From what I could see, the extension just changed the way descriptions are processed/concatenated, which means it should already work with the current preview.

Turhvjbufv commented 1 year ago

Deleted my last comment as it was inaccurate, I thought this was implemented in tachiyomisy not tachiyomi extensions maybe the reason it doesn't work is because it needs to be implemented in tachiyomisy and because tachiyomisy hasn't been updated so it won't work but tachiyomi has been updated so it works

jobobby04 commented 1 year ago

TachiyomiSY contains extra features for mangadex, and one of the things I have to do for that is overwrite the extensions manga info fetcher with a custom one. I need to add support for that setting in SY manually for it to work.