Updating for new version of numpy

jobovy / apogee

Tools for dealing with APOGEE data

BSD 3-Clause "New" or "Revised" License

43 stars 25 forks source link

Updating for new version of numpy #43

Closed npricejones closed 7 years ago

npricejones commented 7 years ago

Had to modify index arrays created with "True-", as this is deprecated in most recent numpy. Replaced with "[not i for i in ]" which doesn't rely on numpy array operations.

jobovy commented 7 years ago

Thanks! But I think an easier way to fix this is to

True- --> True^

where ^ is XOR.

This PR seems to include some other changes as well, are those necessary?

npricejones commented 7 years ago

That seems like a much easier fix - I went with an operation where I was confident it would have the same effect. I think the other changes are from some experimenting I thought was on another deleted branch.

jobovy commented 7 years ago

Could you make these changes on a clean branch, so the other changes aren't included?