Addresses #42. - Githubissues

jobovy / apogee

Tools for dealing with APOGEE data

BSD 3-Clause "New" or "Revised" License

42 stars 25 forks source link

Addresses #42. #53

Closed mrawls closed 5 years ago

mrawls commented 5 years ago

Bugfix where plate ID was mistakenly called location ID
Bugfix for when plate ID and MJD strings had trailing '.0'
Separated data and header loading (users must have multiple calls to apread.apVisit to get both)
Updated README accordingly

jobovy commented 5 years ago

Thanks! I added the telescope keyword everywhere I think it's necessary and adjusted the code to get the filenames. I haven't tested this, so if you could do a quick test to make sure this still works, that would be great!

mrawls commented 5 years ago

I've tried using the code to access and plot a couple different apVisit spectra, and it seems to work. I did not try it with any 1-m spectra, so you may want to do that. At the very least, I can say with high confidence the code is less broken than it used to be!

jobovy commented 5 years ago

Wonderful, thanks for checking, I will merge this then. I'm not too worried about the 1m spectra, if somebody has a problem with those we can always revisit (ha!).