search

jobovy / apogee

Tools for dealing with APOGEE data
BSD 3-Clause "New" or "Revised" License
43 stars 25 forks source link

Inclusion of the APOGEE-2 selection function #55

Closed jmackereth closed 4 years ago

jmackereth commented 5 years ago

This update includes treatment of the APOGEE-2 selection function inside apogee.select. It includes new functionality for loading the individual selection functions of APOGEE-1 and 2, and also for loading a 'Combined' APOGEE-1/2 selection function, which will eventually be applicable to the entire APOGEE data set. The current implementation works for APOGEE DR14, but will eventually be extended for the upcoming DR16 public release.

@jobovy : I updated the README to reflect the new functionality. Hopefully everything is in order!

jmackereth commented 5 years ago

I added some little fixes here to the astroNN inclusion, which was broken if the user had a cached duplicate free file. Now the duplicates are removed every time the allStar is read, if the user is using astroNN...

There was also a slight bug where the SURVEY field strings were read differently depending on the fits reader being used. This was easily repaired now and I think should be general to all installs...

jobovy commented 4 years ago

All looks good now, thanks @jmackereth for all the hard work here!!