Running streamspray example notebook for Orbit initialized by SkyCoord

jobovy / streamtools

Tools for modeling and analyzing stellar streams

https://streamtools.readthedocs.io/

MIT License

1 stars 4 forks source link

Running streamspray example notebook for Orbit initialized by SkyCoord #2

Open nstarman opened 4 years ago

nstarman commented 4 years ago

I ran https://streamtools.readthedocs.io/en/latest/notebooks/streamspray_example.html, but initialized the orbit with a SkyCoord, not list of floats. The function streamspraydf.sample throws a unit conversion error because ro is a quantity, but the internals of streamspray.rtide strips the units from other distances.

jobovy commented 4 years ago

Yeah, streamspraydf does not fully support SkyCoords and Quantity inputs. PR would be welcomed (but we also need some unit tests of streamspraydf first...)

nstarman commented 4 years ago

It could just be a decorator that does .to_value(<unit>) on specified inputs. That might be an easy PR ?