search

jobstoit / hetzner-dns-go

A Go library for the Hetzner DNS API
https://pkg.go.dev/github.com/jobstoit/hetzner-dns-go/dns
MIT License
1 stars 1 forks source link

fix(HdnsTime): check empty string byte array #3

Closed jonasbadstuebner closed 1 year ago

jonasbadstuebner commented 1 year ago

Unfortunately the length check change in #2 broke the parsing of empty strings. So I added a check for the byte array containing bytes representing the JSON empty string.

I tested it this time.

jobstoit commented 1 year ago

Looks good, I realised it might be good to add tests so I'm working on that, maybe you could review that once I have that up