search

jobstoit / hetzner-dns-go

A Go library for the Hetzner DNS API
https://pkg.go.dev/github.com/jobstoit/hetzner-dns-go/dns
MIT License
1 stars 1 forks source link

Add Hetzner timeformat tests #4

Closed jobstoit closed 1 year ago

jobstoit commented 1 year ago

Added tests for the HdnsTime UnmashalJSON

jobstoit commented 1 year ago

Also fixed a listing issue and added some comments

jobstoit commented 1 year ago

@DrBu7cher after merging this we could also increase the tag to 0.1.1 so you can use that in ExternalDNS

jonasbadstuebner commented 1 year ago

Merry christmas! :)

I'm so sorry for not looking into it yesterday. I got the notifications on my work mail address. I didn't mean to push to the branch without asking you, sorry for that too. I think we should add the RFC3339, since it is the format stated in the documentation.

Are you okay with the changes I made? :)

And I would like a new tag, after we merge this. :)

jobstoit commented 1 year ago

Merry Christmas! No worries, looks good. I'll merge this and create the tag 0.1.1