search

jocelyn-stericker / hacklily

A web-based sheet music editor and publishing platform.
https://www.hacklily.org
GNU General Public License v3.0
335 stars 28 forks source link

Is \include expected to work? #29

Open djbclark opened 3 years ago

djbclark commented 3 years ago

Want to use some standard aliases, and if I can get that to work https://github.com/kastdeur/lilydrum but so far getting "Could not render file: Crashed during render: Canary died." on \include statements.

Looking at #5 it seems like this should be possible, unless something has been done since then.

Also posting this as if it's okay I may try to get this to work more intensively, but this would involve using the same kind of commands as mentioned in #5, and I don't want you to think there's a hacking attempt or something.

jocelyn-stericker commented 3 years ago

The list of supported includes is hardcoded at https://github.com/emilyskidsister/hacklily/blob/c785740f328c21451ad53cc8ebd2eccc777f5f8c/server/renderer-server/src/renderer.rs#L70-L132

What file are you trying to include?

Separately, I'd love to add support for including for other files in the user's sheet-music repo.

jocelyn-stericker commented 3 years ago

Also, please do feel free to try whatever input you'd like, but if you find a security issue, please email me directly at jocelyn@nettek.ca rather than post an issue.