search

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle
MIT License
303 stars 67 forks source link

prom-client 15 compatibility #124

Closed yndajas closed 8 months ago

yndajas commented 11 months ago

When trying to update to prom-client 15, we get a TypeScript error related to express-prom-bundle:

node_modules/express-prom-bundle/types/index.d.ts:51:44 - error TS2314: Generic type 'DefaultMetricsCollectorConfiguration<T>' requires 1 type argument(s).

51     promClient?: { collectDefaultMetrics?: DefaultMetricsCollectorConfiguration };

Found 1 error in node_modules/express-prom-bundle/types/index.d.ts:51

Would it be possible to update this package to support prom-client 15?

disjunction commented 8 months ago

v7.0.0 now requires prom-bundle 15 and is compatible with it