Update index.d.ts - Githubissues

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle

MIT License

310 stars 68 forks source link

Closed aaronleesmith closed 5 years ago

aaronleesmith commented 5 years ago

Custom labels was added as an option but never added to the typescript definition file, breaking the usage during typescript compilation.

disjunction commented 5 years ago

@aaronleesmith thanks for the PR.

I'm not an expert with TS, but I noticed after merging... it should be an optional property, right?

See my commit 088ff5a

aaronleesmith commented 5 years ago

You are exactly right, good catch.

disjunction commented 5 years ago

thanks. Published on npm as v5.1.3