feat: add excludeFn - Githubissues

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle

MIT License

303 stars 67 forks source link

Closed raszi closed 3 years ago

raszi commented 5 years ago

With this change we could exclude metrics collection after a request has been handled.

Could be useful for not collecting metrics about non existing paths.

shaikatz commented 4 years ago

Hi, any reason this wasn't merged? it could really be useful for not collecting metrics about non-existing paths.

raszi commented 4 years ago

After taking a second look on this PR. I believe I forgot to implement the excludeRoutes option.

disjunction commented 3 years ago

github did something strange and lost my comment here. Anyway closed in favour of MR 70. See bypass() option.