search

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle
MIT License
310 stars 68 forks source link

No promClient and metricsMiddleware in TypeScript definitions #49

Closed alexeychikk closed 4 years ago

alexeychikk commented 4 years ago

There are no promClient and metricsMiddleware in TypeScript definitions.

const metricsRequestMiddleware = promBundle({ ... });
const { promClient, metricsMiddleware } = metricsRequestMiddleware;
//      ^^^^^^^^^^  ^^^^^^^^^^^^^^^^^
// Property 'promClient' does not exist on type 'RequestHandler<ParamsDictionary>'.
// Property 'metricsMiddleware' does not exist on type 'RequestHandler<ParamsDictionary>'.
jorge07 commented 4 years ago

Merged and released so it can be closed now