search

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle
MIT License
310 stars 68 forks source link

promtool reports errors #72

Closed RichardWright closed 3 years ago

RichardWright commented 3 years ago

Noticed the scrape endpoint was working with prometheus so ran the prom tool. I got the following output

'nodejs_active_handles_total non-counter metrics should not have "_total" suffix'

As this is standard stuff how is this working for everyone else?

disjunction commented 3 years ago

I was using the recommendation from Prometheus itself. It seems to be the same as before: https://prometheus.io/docs/practices/naming/

In the first version is was named differently and I was told off by the Prometheus community ;), and thus changed the label to what it is now.

Please provide more details on your argument and make a concrete suggestion, if you feel the label is wrong.